KAFKA-17600: Add nextOffsets to the ConsumerRecords

Open aliehsaeedii opened this issue 1 year ago • 4 comments

This PR implements KIP-1094.

Oct 08 '24 15:10 aliehsaeedii

@lucasbru

I suppose (without checking further) that this would mean that partRecords is empty here.

I assume when control records are returned, partRecords is empty while the position is advanced.

Oct 11 '24 13:10 aliehsaeedii

I assume when control records are returned, partRecords is empty while the position is advanced.

You are right. Anyway, I'd assume we add a TP to nextOffsets if the position advanced.

I can have a look again tomorrow or next week to see if all comments have been addressed, and potentially merge it.

Oct 11 '24 14:10 lucasbru

Thanks @AndrewJSchofield for the pointer. Yes, I followed the code, and as I stated before, when a control record is returned, the size of partRecords is 0 while the offset is updated.

Oct 14 '24 17:10 aliehsaeedii

@lucasbru I think the PR is ready for the last round of review. Thanks in advance.

Oct 14 '24 19:10 aliehsaeedii