kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-15909: Throw error when consumer configured with empty/whitespace-only group.id for LegacyKafkaConsumer

Open FrankYang0529 opened this issue 1 year ago • 4 comments

Per KIP-289, the use of an empty value for group.id configuration was deprecated back in 2.2.0.

In 3.7, the AsyncKafkaConsumer implementation will throw an error (see KAFKA-14438).

This task is to update the LegacyKafkaConsumer implementation to throw an error in 4.0.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

FrankYang0529 avatar Aug 20 '24 11:08 FrankYang0529

@FrankYang0529 please check the failed tests

chia7712 avatar Aug 20 '24 20:08 chia7712

@FrankYang0529 please check the failed tests

Updated it. Latest failed cases can pass on my laptop.

FrankYang0529 avatar Aug 22 '24 01:08 FrankYang0529

@FrankYang0529 could you please rebase code to trigger QA again?

chia7712 avatar Aug 26 '24 01:08 chia7712

@FrankYang0529 could you please rebase code to trigger QA again?

Rebased it. Thank you.

FrankYang0529 avatar Aug 26 '24 01:08 FrankYang0529