kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-17045: Move MetadataLogConfig from kafka to kafka/raft

Open ulysses-you opened this issue 1 year ago • 2 comments

The MetadataLogConfig belongs to raft, move file to raft to mach the package name.

Committer Checklist (excluded from commit message)

  • [x] Verify design and implementation
  • [x] Verify test coverage and CI build status
  • [x] Verify documentation (including upgrade notes)

ulysses-you avatar Jun 27 '24 08:06 ulysses-you

cc @jsancio @chia7712 if you have time to take a look, thank you.

ulysses-you avatar Jun 28 '24 00:06 ulysses-you

not sure whether it is good time to do this migration since KafkaMetadataLog is still in core module ..

chia7712 avatar Jul 01 '24 15:07 chia7712

@chia7712 yeah, but the MetadataLogConfig is also in core module, which means this pr only move the file from core/src/main/scala/kafka/MetadataLogConfig.scala to core/src/main/scala/kafka/raft/MetadataLogConfig.scala.

ulysses-you avatar Jul 02 '24 01:07 ulysses-you

not sure whether it is good time to do this migration since KafkaMetadataLog is still in core module ..

I agree, the long term future is to move a lot of those classes to raft or metadata module once Scala is not used by Kafka anymore.

jsancio avatar Jul 04 '24 19:07 jsancio

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jan 05 '25 03:01 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Feb 05 '25 03:02 github-actions[bot]