kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-3346: Refactor & Rename Mode to ConnectionMode

Open abhi-ksolves opened this issue 1 year ago • 3 comments

I have renamed the Mode enum to ConnectionMode in the clients to improve clarity. The previous name, Mode, was undocumented and ambiguous. This made it unclear whether the connection was for an SSL client or an SSL server.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

abhi-ksolves avatar Jun 20 '24 11:06 abhi-ksolves

@abhi-ksolves could you please share you jira account to me? I'd like to assign KAFKA-3346 to you

chia7712 avatar Jun 20 '24 16:06 chia7712

@chia7712 I have already assigned myself to this ticket.

abhi-ksolves avatar Jun 20 '24 16:06 abhi-ksolves

@chia7712 Mentioned changes are done. Hope this can be merged now.

abhi-ksolves avatar Jun 22 '24 12:06 abhi-ksolves

Hi @chia7712 Can you look into this PR

We can merge this?

abhi-ksolves avatar Jul 02 '24 08:07 abhi-ksolves

@abhi-ksolves thanks for this contribution

chia7712 avatar Jul 02 '24 18:07 chia7712