kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-16959: ConfigCommand should allow to define both `entity-default` and `entity-name`

Open m1a2st opened this issue 1 year ago • 12 comments

https://issues.apache.org/jira/browse/KAFKA-16959 add new check and test fot can't allow both parameter

waiting for https://github.com/apache/kafka/pull/16317

m1a2st avatar Jun 18 '24 06:06 m1a2st

@m1a2st Could you please add jira number? Also, please take a look at the discussion of https://issues.apache.org/jira/browse/KAFKA-16959.

chia7712 avatar Jun 19 '24 06:06 chia7712

@chia7712, Thanks for your comment, PTAL

m1a2st avatar Jun 22 '24 15:06 m1a2st

@m1a2st could you please update title?

chia7712 avatar Jun 23 '24 15:06 chia7712

Gentle ping, @chia7712, I update the title

m1a2st avatar Jun 23 '24 17:06 m1a2st

@m1a2st Could you take a look at other ConfigTypes? I feel they can support both entity-default and entity-name too

chia7712 avatar Jul 05 '24 08:07 chia7712

@chia7712, Thanks for your comments, I will take a look at another types.

m1a2st avatar Jul 05 '24 08:07 m1a2st

@chia7712, Thanks for your comments, PTAL

m1a2st avatar Jul 07 '24 06:07 m1a2st

@chia7712, add new test for InvalidConfigurationException, PTAL, Thanks

m1a2st avatar Jul 11 '24 12:07 m1a2st

rebase on the trunk, and fix the conflict

m1a2st avatar Sep 23 '24 16:09 m1a2st

Can you please correct the title as per the jira i.e. .....should not allow.....

apoorvmittal10 avatar Sep 25 '24 16:09 apoorvmittal10

Can you please correct the title as per the jira i.e. .....should not allow.....

After discussion, we've decided to allow defining both entity-default and entity-name. This makes sense, as Admin#incrementalAlterConfigs supports it, so there's no reason to disable it in the command tool. @m1a2st Could you please correct the title for the jira?

chia7712 avatar Sep 25 '24 20:09 chia7712

@chia7712, @apoorvmittal10, Thanks for your reminder, I will update the Jira Title.

m1a2st avatar Sep 25 '24 23:09 m1a2st