kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-16840 [WIP]: Add --timeout option for ConfigCommand

Open veepeeaee opened this issue 1 year ago • 3 comments

The alter config command sometimes takes longer than the default timeout of 30s. Adding a --timeout option helps in thise cases.

Testing

  • unit tests (existing and new) passing
  • integration tests (existing) passing

This contribution is my original work and I license the work to the project under the project's open source license.

veepeeaee avatar May 28 '24 18:05 veepeeaee

Hey @vishalpalla, this looks helpful indeed, just like it's allowed in other places. But adding a new argument to this command line tool would be a change to the public interface so it would require a KIP I expect (as defined here).

lianetm avatar May 28 '24 19:05 lianetm

Hi @lianetm - thanks for the review. Yep, I see that now. Let me create a KIP and get feedback.

veepeeaee avatar May 28 '24 20:05 veepeeaee

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Aug 27 '24 03:08 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Jan 05 '25 03:01 github-actions[bot]