kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java

Open nizhikov opened this issue 1 year ago • 7 comments

This is fourth part of https://github.com/apache/kafka/pull/15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains tests of DynamicBrokerReconfigurationTest that checks ConfigCommand rewritten in java.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

nizhikov avatar May 02 '24 15:05 nizhikov

Please ping me if this PR gets ready :)

chia7712 avatar May 21 '24 14:05 chia7712

Yes. I'm working on it right now. Will be ready in a couple of hours.

nizhikov avatar May 21 '24 14:05 nizhikov

@chia7712 PR ready for review.

nizhikov avatar May 21 '24 15:05 nizhikov

CI looks OK for me.

DynamicBrokerReconfigurationTest#testTrustStoreAlter fails in trunk, also.

https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/detail/trunk/2933/tests

nizhikov avatar May 25 '24 06:05 nizhikov

I just notice that this test requires SaslSetup. the new test infra does not support that for now (https://issues.apache.org/jira/browse/KAFKA-16680). Hence, I'd like to pending this rewrite as we can't do the migration recently...

chia7712 avatar May 27 '24 09:05 chia7712

Got it.

nizhikov avatar May 27 '24 09:05 nizhikov

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Aug 26 '24 03:08 github-actions[bot]