kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-16231: Update consumer_test.py to support KIP-848’s group protocol config

Open kirktrue opened this issue 1 year ago • 1 comments

Added a new optional group_protocol parameter to the test methods, then passed that down to the setup_consumer method.

Unfortunately, because the new consumer can only be used with the new coordinator, this required a new @matrix block instead of adding the group_protocol=["classic", "consumer"] to the existing blocks 😢

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

kirktrue avatar Feb 07 '24 02:02 kirktrue

looks good. As you said, we shouldn't merge this yet as long as some are not passing. Could we follow a similar approach as with the integration tests, enable the ones that are passing, and leave the failing ones disabled, ideally linking a ticket?

lucasbru avatar Feb 07 '24 09:02 lucasbru

@lucasbru can you take another look at this PR? Thanks!

kirktrue avatar Feb 27 '24 23:02 kirktrue

Could we follow a similar approach as with the integration tests, enable the ones that are passing, and leave the failing ones disabled, ideally linking a ticket?

Yes, this is the approach I took. Right now, the all_group_protocols list (defined in consumer_group.py) is—for the time being—just a list of one: the "classic" consumer.

kirktrue avatar Feb 27 '24 23:02 kirktrue

LGTM, thanks!

lucasbru avatar Mar 15 '24 13:03 lucasbru