kafka
kafka copied to clipboard
KAFKA-16231: Update consumer_test.py to support KIP-848’s group protocol config
Added a new optional group_protocol
parameter to the test methods, then passed that down to the setup_consumer
method.
Unfortunately, because the new consumer can only be used with the new coordinator, this required a new @matrix
block instead of adding the group_protocol=["classic", "consumer"]
to the existing blocks 😢
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
looks good. As you said, we shouldn't merge this yet as long as some are not passing. Could we follow a similar approach as with the integration tests, enable the ones that are passing, and leave the failing ones disabled, ideally linking a ticket?
@lucasbru can you take another look at this PR? Thanks!
Could we follow a similar approach as with the integration tests, enable the ones that are passing, and leave the failing ones disabled, ideally linking a ticket?
Yes, this is the approach I took. Right now, the all_group_protocols
list (defined in consumer_group.py
) is—for the time being—just a list of one: the "classic" consumer.
LGTM, thanks!