kafka
kafka copied to clipboard
MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit
ReplicaManagerTest::setupReplicaManagerWithMockedPurgatories
creates two log dirs, core/data
and core/data2
and test testActiveProducerState
creates a partition in core/data2
.
This PR adds core/data2
and all files/directories within it to .gitignore
.
CC: @mimaison, please take a look
Shouldn't we instead update the tests to use temp directories and cleanup any files they create?
I agree with @mimaison, I think we should make sure the tests clean after themselves. Right now, it seems that data within core/data/
is deleted but the directories are still present.
Addressed in 4406670
Shouldn't we instead update the tests to use temp directories and cleanup any files they create?
I think the tests deliberately use relative directories because of KAFKA-5759.