kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-15821: Delete active topics after connector deletion in standal…

Open djameson42 opened this issue 2 years ago • 2 comments

Fixes a bug where the active topics for a connector are not removed when the connector is deleted if connect is running in standalone mode.

https://issues.apache.org/jira/browse/KAFKA-15821

djameson42 avatar Nov 16 '23 02:11 djameson42

Thanks for the PR @djameson42! I agree with @hudeqi that we should have a test to cover this change and prevent regression.

Also, not a blocker, but it seems a little strange to put this new logic in the config update listener instead of in StandaloneHerder::deleteConnectorConfig, which is where almost all of the existing connector deletion logic is located. Any particular reason you've structured things this way?

C0urante avatar Nov 25 '23 22:11 C0urante

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Feb 24 '24 03:02 github-actions[bot]