KAFKA-15170: CooperativeStickyAssignor may fail adjust assignment

[flashmouse]

ConstrainedAssignmentBuilder in AbstractStickyAssignor cannot build partitionsTransferringOwnership correctly, that would result in execute adjustAssignment fail in CooperativeStickyAssignor

[flashmouse]

please note another bugs in this implementation.

the function assignRackAwareRoundRobin of ConstrainedAssignmentBuilder have 2 logical error:

1. (about line 726)when assignmentCount >= minQuota, the consumer should be added to

unfilledMembersWithExactlyMinQuotaPartitions only if

currentNumMembersWithOverMinQuotaPartitions < expectedNumMembersWithOverMinQuotaPartitions

2. (about line 739)unfilledMembersWithExactlyMinQuotaPartitions should execute clear when

assignment.get(consumer).size() + 1 == maxQuota.

this error will lead to fail execute verifyUnfilledMembers, throw exception, raise new rebalance and return the same assignment result so group may stuck forever.

[flashmouse]

please note another bugs in this implementation.

the function assignRackAwareRoundRobin of ConstrainedAssignmentBuilder have 2 logical error:

1. (about line 726)when assignmentCount >= minQuota, the consumer should be added to

unfilledMembersWithExactlyMinQuotaPartitions only if

currentNumMembersWithOverMinQuotaPartitions < expectedNumMembersWithOverMinQuotaPartitions

2. (about line 739)unfilledMembersWithExactlyMinQuotaPartitions should execute clear when

assignment.get(consumer).size() + 1 == maxQuota.

this error will lead to fail execute verifyUnfilledMembers, throw exception, raise new rebalance and return the same assignment result so group may stuck forever.

I suggest verifyUnfilledMembers shouldn't throw Exception because the error it checks only caused to assignment not full balance, but is still a valid result, we cannot allow rebalance stuck forever in such situation.

[flashmouse]

@rreddy-22 I see you are familiar with this implementation, plz help me check this, thx!

[github-actions[bot]]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[ableegoldman]

@flashmouse can you rebase this PR please?

[flashmouse]

updated to latest commit now @ableegoldman

[ableegoldman]

Test failures are unrelated, merging to trunk

[ableegoldman]

Merged to trunk and cherrypicked back to 3.7