kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Enable KStream to be merged with itself

Open Danny02 opened this issue 2 years ago • 1 comments

Why: It is an interesting question what should be the result when merging a KStream with itself. Should the merge duplicate the messages or should it be a noop. I think the only reasonable solution is to duplicate the messages because there are many different ways to disguise a KStream (e.g. adding peek operation on it). It is therefore impossible to implement the solution where it is a noop.

How does it help with resolving the issue: This change makes the behavior of the merge operation consistent.

Danny02 avatar Sep 08 '22 15:09 Danny02

I have really no idea why completely different tests are failing.

Danny02 avatar Sep 09 '22 09:09 Danny02

Can you create a JIRA ticket for this PR? If it's not working right now, I would consider it a bug.

And yes, I agree that merging a KStream with itself should result in duplicating each record.

For the tests, it's most likely flaky test.

mjsax avatar Dec 28 '22 20:12 mjsax

@Danny02 -- Are you still interested to finish this PR?

mjsax avatar Jan 12 '23 22:01 mjsax

Closing this PR due to inactivity. Feel free to resume at any time -- and we should have a Jira for this.

mjsax avatar Oct 13 '23 01:10 mjsax