kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

MINOR: Include all hosts in metadata for topology

Open wcarlson5 opened this issue 2 years ago • 2 comments

When building streams metadata we want to build even if the host is empty as it is a common way to find the other host addresses

update existing tests to find all hosts

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

wcarlson5 avatar Sep 06 '22 19:09 wcarlson5 

[2022-09-07T15:38:17.417Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12594/streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java:64:8: Unused import - java.util.Collections. [UnusedImports]

vvcephei avatar Sep 19 '22 12:09 vvcephei

@vvcephei Wow every single test passed. Don't see that very often on a pr

wcarlson5 avatar Sep 22 '22 16:09 wcarlson5

Wow every single test passed. Don't see that very often on a pr

Yeah that is legitimately amazing. Love to see it! Maybe things are turning around...heh... 😭

ableegoldman avatar Oct 07 '22 04:10 ableegoldman