kafka
kafka copied to clipboard
KAFKA-13991: Add Admin.updateFeatures with default options
More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers. We have Admin.updateFeatures(Map<String, FeatureUpdate>, UpdateFeaturesOptions) but don't have Admin.updateFeatures(Map<String, FeatureUpdate>), this is inconsistent with other Admin API.
Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Do we have an existing KIP to cover this?
Do we have an existing KIP to cover this?
I think this is an omission of KIP-584, we only mention describeFeatures(DescribeFeaturesOptions options)
and updateFeatures(Map<String, FeatureUpdate> featureUpdates, UpdateFeaturesOptions options)
in "Admin API changes" section, and in Admin
we 2 describeFeatures
and only one updateFeatures
.
@dajac Do you think we should have a KIP for this? I also find we lack aremoveMembersFromConsumerGroup()
in Admin
, we can also add it in that KIP.