kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: Fix locking in GroupMetadataManager's metrics

Open dajac opened this issue 3 years ago • 1 comments

Using group synchronized when accessing the group state does not seem to be correct because the group is protected by a lock. Instead we should use group.inLock.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

dajac avatar Aug 19 '22 09:08 dajac

I can't see where's the difference between synchronized and inLock, either. Could you please explain more?

showuon avatar Aug 21 '22 12:08 showuon