KAFKA-14133: Replace EasyMock with Mockito in streams tests

[clolov]

Batch 2 of the tests detailed in https://issues.apache.org/jira/browse/KAFKA-14133 which use EasyMock and need to be moved to Mockito.

[clolov]

Tagging @mdedetrich @cadonna @ijuma for visibility and reviews :)

[mdedetrich]

Thanks, will review today!

[clolov]

I am aware checkstyle is complaining about some indentation which I will fix later throughout the day.

[clolov]

Hey @dplavcic, thank you for the comments. I will aim to provide an answer in the next couple of days!

[mdedetrich]

@clolov Sorry for not reviewing earlier, I ended up doing some work myself for the EasyMock to Mockito migration so I have better context/background info. Will review the PR later today.

[clolov]

Heya @cadonna and thank you very much for the review! I will address your comments over the next few days.

[cadonna]

@clolov What is the status of this PR?

[clolov]

Hello @cadonna. Apologies, I am back on having bandwidth to move this (and the rest of the pull requests) to a conclusion. I will post an update later today.

[clolov]

The build is failing because of checkstyle problems:

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java:268:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java:279:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentSessionStoreTest.java:290:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemorySessionStoreTest.java:273:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemorySessionStoreTest.java:284:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemorySessionStoreTest.java:295:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java:1045:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java:1056:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java:1067:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemoryKeyValueStoreTest.java:157:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemoryKeyValueStoreTest.java:169:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

[2022-11-02T14:01:43.975Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-12505/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemoryKeyValueStoreTest.java:181:17: Variable 'inOrder' should be declared final. [FinalLocalVariable]

I will address this as soon as possible.

[cadonna]

I restarted the builds to ensure everything is still fine with current trunk since they were run 18 days ago last time. If the builds are acceptable, I will merge the PR.

[cadonna]

Build failures are not related:

Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslVersionsTransportLayerTest.tlsServerProtocol = [TLSv1.2, TLSv1.3], tlsClientProtocol = [TLSv1.3]
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[6] magic=2, bufferOffset=0, compressionType=gzip
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[9] magic=2, bufferOffset=0, compressionType=snappy
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[10] magic=0, bufferOffset=0, compressionType=lz4
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[15] magic=1, bufferOffset=15, compressionType=none
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[18] magic=1, bufferOffset=15, compressionType=gzip
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[22] magic=2, bufferOffset=15, compressionType=snappy
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[24] magic=1, bufferOffset=15, compressionType=lz4
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[26] magic=2, bufferOffset=15, compressionType=zstd
Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector

[clolov]

Yay 🎉 , thank you for your help in reviewing, approving and merging this @cadonna!