kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: Update site docs for ASF compliance

Open bbejeck opened this issue 2 years ago • 6 comments

This PR is a mirror of https://github.com/apache/kafka-site/pull/433 which used placeholder images for the Kafka Streams that users need to click in order to load the iframe with the corresponding video.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

bbejeck avatar Aug 08 '22 19:08 bbejeck

ping @mimaison

bbejeck avatar Aug 08 '22 19:08 bbejeck

The path of the images is /{{version}}/images/, so do we need to add them to this repo too?

mimaison avatar Aug 09 '22 09:08 mimaison

The path of the images is /{{version}}/images/, so do we need to add them to this repo too?

Yes I overlooked that - will do

bbejeck avatar Aug 09 '22 12:08 bbejeck

@mimaison added images

bbejeck avatar Aug 09 '22 13:08 bbejeck

Thanks @bbejeck ! Should we fix the issues I reported in https://github.com/apache/kafka-site/pull/433#issuecomment-1205049698 before merging the images back to Kafka?

mimaison avatar Aug 09 '22 13:08 mimaison

Should we fix the issues I reported in apache/kafka-site#433 (comment) before merging the images back to Kafka?

I've taken a stab at addressing those comments - this may be the best I can do

bbejeck avatar Aug 09 '22 19:08 bbejeck

@bbejeck Can we grab the images from https://github.com/apache/kafka-site/pull/435 ?

mimaison avatar Aug 24 '22 10:08 mimaison

@mimaison updated images added

bbejeck avatar Aug 24 '22 14:08 bbejeck

Merged #12494 into trunk

bbejeck avatar Aug 24 '22 14:08 bbejeck

cherry-picked to 3.3

bbejeck avatar Aug 24 '22 14:08 bbejeck