kafka
kafka copied to clipboard
MINOR: Update site docs for ASF compliance
This PR is a mirror of https://github.com/apache/kafka-site/pull/433 which used placeholder images for the Kafka Streams that users need to click in order to load the iframe
with the corresponding video.
Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
ping @mimaison
The path of the images is /{{version}}/images/
, so do we need to add them to this repo too?
The path of the images is
/{{version}}/images/
, so do we need to add them to this repo too?
Yes I overlooked that - will do
@mimaison added images
Thanks @bbejeck ! Should we fix the issues I reported in https://github.com/apache/kafka-site/pull/433#issuecomment-1205049698 before merging the images back to Kafka?
Should we fix the issues I reported in apache/kafka-site#433 (comment) before merging the images back to Kafka?
I've taken a stab at addressing those comments - this may be the best I can do
@bbejeck Can we grab the images from https://github.com/apache/kafka-site/pull/435 ?
@mimaison updated images added
Merged #12494 into trunk
cherry-picked to 3.3