kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

KAFKA-14133: Replace EasyMock with Mockito in streams tests

Open clolov opened this issue 2 years ago • 2 comments

Batch 1 of the tests detailed in https://issues.apache.org/jira/browse/KAFKA-14133 which use EasyMock and need to be moved to Mockito.

clolov avatar Aug 08 '22 11:08 clolov

Hello @cadonna and @ijuma! Tagging you for visibility.

clolov avatar Aug 08 '22 11:08 clolov

Also @mdedetrich since you volunteered a pair of eyes for reviews :)

clolov avatar Aug 08 '22 11:08 clolov

Thank you @cadonna and @dplavcic for your comments. I will aim to address them as soon as possible.

clolov avatar Aug 15 '22 18:08 clolov

@cadonna and @dplavcic I hope that the new version has addressed all comments up to now. Thank you in advance for the review!

clolov avatar Aug 17 '22 08:08 clolov

@cadonna and @dplavcic I hope that the new version has addressed all comments up to now. Thank you in advance for the review!

LGTM!

dplavcic avatar Aug 18 '22 16:08 dplavcic

@cadonna a polite bump for review :)

clolov avatar Sep 05 '22 15:09 clolov

Build failures are unrelated:

Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testDelayedConfigurationOperations()

cadonna avatar Sep 07 '22 08:09 cadonna