kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: Support --release in FeatureCommand

Open dengziming opened this issue 2 years ago • 3 comments

More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.

Support --release in FeatureCommand, currently, we only have one feature which is metadata.version.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Added a test case in FeatureCommandTest

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

dengziming avatar Jun 21 '22 08:06 dengziming

cc @mumrah

dengziming avatar Jul 04 '22 03:07 dengziming

@mumrah Thank you for your reminder, I added --release support for describing and added a unit test for it.

dengziming avatar Jul 14 '22 13:07 dengziming

@mumrah Do we still need --release after we add --metadata? I will close this if it's unnecessary or rebase this PR onto trunk if it's still useful.

dengziming avatar Sep 15 '22 06:09 dengziming

Closing this since we are using --metadata instead of --release.

dengziming avatar May 09 '23 08:05 dengziming