kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

MINOR: Update the README file in examples.

Open liuzhuang2017 opened this issue 3 years ago • 1 comments

  • I think the Intellij should be changed to IntelliJ IDEA. For details, please refer to the official website https://www.jetbrains.com/idea/ and https://en.wikipedia.org/wiki/IntelliJ_IDEA.
  • Modify Intellij to IntelliJ IDEA.
  • This change is a trivial rework / code cleanup without any test coverage.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

liuzhuang2017 avatar Jun 09 '22 03:06 liuzhuang2017

@dajac ,Sorry to bother you, can you help me review this pr? Thank you.

liuzhuang2017 avatar Jun 21 '22 09:06 liuzhuang2017

I searched the whole project, and there are 3 occurrences of "Intellij", please change them all. And in this README file, the first step is "Start Zookeeper and the Kafka server", I think we can also improve it as a convenience, for example, it's unnecessary to start Zookeeper in KRaft mode.

dengziming avatar Oct 11 '22 04:10 dengziming

@dengziming OK, thanks your review, I have updated this pr.

liuzhuang2017 avatar Oct 11 '22 07:10 liuzhuang2017

@dengziming ，Thanks your review, I have updated this pr according to your suggestion.

liuzhuang2017 avatar Oct 12 '22 02:10 liuzhuang2017

@dengziming , Thanks your review，I have updated the pr.

liuzhuang2017 avatar Oct 12 '22 04:10 liuzhuang2017