kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-13817 Always sync nextTimeToEmit with wall clock

Open qingwei91 opened this issue 2 years ago • 1 comments

We should sync nextTimeToEmit with wall clock on each method call to ensure throttling works correctly in case of clock drift. If we dont, then in the event of significant clock drift, throttling might not happen for a long time, this can hurt performance.

I've added a unit test to simulate clock drift and verify my change works.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

qingwei91 avatar May 16 '22 13:05 qingwei91

I can also take a look by end of this week.

lihaosky avatar Jul 06 '22 17:07 lihaosky

@qingwei91 -- What is the status of this PR? Seems there is open comments that would need to be addressed? Would be great if we could push this over the finish line.

mjsax avatar Nov 02 '22 23:11 mjsax

@mjsax sorry, I will try to pick this back up this weekend

qingwei91 avatar Nov 03 '22 21:11 qingwei91

@mjsax can help approve and merge as a committer.

lihaosky avatar Nov 07 '22 21:11 lihaosky

Thanks for the PR! Merged to trunk.

mjsax avatar Dec 28 '22 20:12 mjsax