kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-13850: Show missing record type in MetadataShell

Open dengziming opened this issue 2 years ago • 1 comments

More detailed description of your change Currently, 8 record types are missing in MetadataShell:

  1. AccessControlEntryRecord and RemoveAccessControlEntryRecord are added in KIP-801, FeatureLevelRecord and maybe RemoveFeatureLevelRecord will be added in KIP-778, I added these 4 record types in MetadataShell.
  2. AccessControlRecord will not be used since we use AccessControlEntryRecord.
  3. UserScramCredentialRecord, DelegationTokenRecord and BrokerRegistrationChangeRecord will be used in the future, but we can't make sure whether their schema be changed, just like AccessControlRecord which is outdated. so I didn't added them here.

Summary of testing strategy (including rationale) Unit tests

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

dengziming avatar Apr 28 '22 02:04 dengziming

ping @mumrah

dengziming avatar Aug 04 '22 09:08 dengziming

@jsancio , I think we should make this fix into v3.3, otherwise, the metadata shell is basically broken. WDYT? @dengziming , could you help confirm if this patch contain all record types we have now? Thanks.

showuon avatar Aug 24 '22 02:08 showuon

Thank you! Let's wait for the jenkins build. @jsancio , I'm going to backport this patch to 3.3 tomorrow if you have no objection. Thanks.

showuon avatar Aug 24 '22 07:08 showuon

Failed tests are un-related:

Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment()

showuon avatar Aug 25 '22 06:08 showuon

backport to 3.3

showuon avatar Aug 25 '22 06:08 showuon

Sorry for the delay @dengziming, yes this is needed for 3.3. Thanks!

mumrah avatar Aug 25 '22 13:08 mumrah