kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: Add shebang to gradlewAll

Open akatona84 opened this issue 3 years ago • 5 comments

More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

akatona84 avatar Oct 01 '21 07:10 akatona84

@ijuma could you approve this change pls?

Python based build executor died because of it:

OSError: [Errno 8] Exec format error: './gradlewAll'

akatona84 avatar Oct 01 '21 07:10 akatona84

@granthenke , could you take a look as well? Thanks!

akatona84 avatar Oct 04 '21 16:10 akatona84

@ijuma would you please quickly review this small pr?

viktorsomogyi avatar Oct 05 '21 10:10 viktorsomogyi

@ijuma I've added the same shebang as gradlew has to gradlewAll. Could you check it pls? 🥺 🎅 🎄 😄

akatona84 avatar Dec 03 '21 14:12 akatona84

@omkreddy , @ijuma could you take a look? pretty small change, pretty pls :)

akatona84 avatar Sep 20 '22 12:09 akatona84

@mimaison would you please check this quickly? (I think the test failures are unrelated as this only affects the command line)

viktorsomogyi avatar Oct 06 '22 11:10 viktorsomogyi