kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Published 20 hours ago • verified publisher icon apache

KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

Open wycccccc opened this issue 3 years ago • 13 comments

Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and are not actively maintained. In addition, Mockito is also easier to use.KAFKA-7438

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

wycccccc avatar Jun 14 '21 17:06 wycccccc

Thanks for the PR. Can we please update https://github.com/apache/kafka/blob/trunk/build.gradle#L374 as well?

ijuma avatar Jun 15 '21 12:06 ijuma

@ijuma Thanks for the hint，have updated.

wycccccc avatar Jun 15 '21 16:06 wycccccc

@vvcephei @ableegoldman can one of you review this PR please? It gets us closer to disabling the JDK 15 builds.

ijuma avatar Jun 28 '21 02:06 ijuma

cc also @cadonna who's familiar with these specific tests I think

ableegoldman avatar Jul 21 '21 20:07 ableegoldman

I think this looks good but there's a merge conflict, can you fix that?

ableegoldman avatar Jul 29 '21 02:07 ableegoldman

@ableegoldman Have resloved conflict, thanks for your review.

wycccccc avatar Jul 29 '21 15:07 wycccccc

@wycccccc Are you planning to address the outstanding review comments?

ijuma avatar Sep 06 '21 15:09 ijuma

@ijuma Sure,I have resolved the problem.If there are other problems, I will solve them immediately.

wycccccc avatar Sep 08 '21 17:09 wycccccc

Hello @ijuma, @ableegoldman, @wycccccc! I have been working on trying to upgrade Kafka Streams from JUnit 4 to JUnit 5 (https://issues.apache.org/jira/browse/KAFKA-7342) and I was wondering what is the state of this pull request and all the ones listed in https://issues.apache.org/jira/browse/KAFKA-7438? Is there something I can help with to get them to completion?

clolov avatar Jun 13 '22 09:06 clolov

@clolov Thank you for your interest and help! Since this PR was not touched more than half a year, I would be fine to close it and you can open a new one.

cadonna avatar Jun 15 '22 12:06 cadonna

@wycccccc Do you plan to still work on this PR?

cadonna avatar Jun 15 '22 12:06 cadonna

Thank you for the reply @cadonna! Okay, I will wait for a week starting today and I will try to reach out to @wycccccc over email as well should I manage to find it across GitHub or JIRA. If I do not get a response I will then open new pull requests.

clolov avatar Jun 16 '22 10:06 clolov

Thank you for the reply @cadonna! Okay, I will wait for a week starting today and I will try to reach out to @wycccccc over email as well should I manage to find it across GitHub or JIRA. If I do not get a response I will then open new pull requests.

@clolov, I see you're working intensively on the Migrate streams modules to JUnit 5 (which is great), and I hope you don't mind me jumping in and helping with what was started in the Replace EasyMock and PowerMock with Mockito.

I have created a new PR #12449 for this since the initial author is no longer accessible.

dplavcic avatar Jul 28 '22 04:07 dplavcic