jspwiki icon indicating copy to clipboard operation
jspwiki copied to clipboard

JSPWIKI-1188 system property expansion

Open spyhunter99 opened this issue 2 years ago • 1 comments

see https://issues.apache.org/jira/browse/JSPWIKI-1188

spyhunter99 avatar Mar 30 '24 15:03 spyhunter99

this actually didn't work when i tested it in tomcat. investigating now

spyhunter99 avatar Mar 31 '24 15:03 spyhunter99

cycling back around to this. looks like the last commit i made does it fact work. i'm not sure why the tests failed (works on my machine lol). test failure is related to email notifications...i didn't touch any of that. any guidance from the JSPWiki team?

spyhunter99 avatar Apr 27 '24 13:04 spyhunter99

Hi, just added a commit on the PR to also allow system env variable expansion, with the tests also passing; let's merge this and get a look to ci build then

juanpablo-santos avatar Apr 27 '24 13:04 juanpablo-santos

this is now merged in 2.12.2-git-13, thanks! :-)

juanpablo-santos avatar Apr 27 '24 13:04 juanpablo-santos

re. the build failure, MailUtilTest does send a mail to a local mailbox, and seems that up recently it doesn't allow mail sending if not using at least TLSv1.2. Currently running build at master should fix that issue, and I've also enabled console output on surefire on test failures/errors so hopefully debugging will be easier from now on.

juanpablo-santos avatar Apr 27 '24 14:04 juanpablo-santos

could try dumpster. it's a pure java, unit test only, mail server setup. We used it on apache juddi for integration tests. works fairly well for plain text stuff. never tried it with ssl though

spyhunter99 avatar Apr 27 '24 15:04 spyhunter99