johnzon icon indicating copy to clipboard operation
johnzon copied to clipboard

JOHNZON-398: full JPMS support via module-info.java mechanism

Open SingingBush opened this issue 2 years ago • 2 comments

This is a follow up to #99 which merely configured Automatic-Module-Name

  • Updated a few maven plugins
  • Add module-info.java to all sub-projects that makes sense to do so
  • Remove Automatic-Module-Name in all sub-projects that now have module-info.java
  • Also added a README.md

SingingBush avatar Jun 10 '23 10:06 SingingBush

No problem. May be worth keeping the branch for reference. I'd like to know more about how the intended approach to JPMS would work and can potentially have a go at redoing the PR. I have no legacy projects in my current firm so have been able to make use of modules in all codebases. Personally I find it great and can use the maven jlink plugin to build small apps.

SingingBush avatar Jun 10 '23 16:06 SingingBush

Have to admit we tested jlink and found no advantage over plain custom jvm (but same licenses issues), we tend to move to graalvm for small and optimized apps (with arthur for a trivial jsonb integration) or plain jvm for other oci apps to leverage layer cache so jlink is really something in between without much real use cases IMHO. Most of the use case i saw was perf boost of wrongly configured app (not comparable scanning due to module usage) and adoption stays low in the ecosystem. That said the breaking change is more an immediate blocker but happy to get classified jar if it helps you.

rmannibucau avatar Jun 10 '23 18:06 rmannibucau