jmeter icon indicating copy to clipboard operation
jmeter copied to clipboard

[65318] JSON Assertion: Use correct number format

Open andreaslind01 opened this issue 3 years ago • 1 comments

Description

See https://bz.apache.org/bugzilla/show_bug.cgi?id=65318

Motivation and Context

This PR fixes the issues with JSON Assertions mentioned here: https://bz.apache.org/bugzilla/show_bug.cgi?id=65318

How Has This Been Tested?

Tested with the example testplan provided in the issue.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have updated the documentation accordingly.

andreaslind01 avatar Aug 09 '22 05:08 andreaslind01

Codecov Report

Merging #723 (c337824) into master (b73f690) will increase coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #723   +/-   ##
=========================================
  Coverage     55.24%   55.24%           
- Complexity    10386    10387    +1     
=========================================
  Files          1062     1062           
  Lines         65777    65777           
  Branches       7536     7536           
=========================================
+ Hits          36337    36339    +2     
+ Misses        26839    26838    -1     
+ Partials       2601     2600    -1     
Impacted Files Coverage Δ
...rg/apache/jmeter/assertions/JSONPathAssertion.java 78.57% <0.00%> (ø)
...a/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0.00%> (+5.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73f690...c337824. Read the comment docs.

codecov-commenter avatar Aug 30 '22 22:08 codecov-commenter

This was created to address #5539, but the attached test case does not fail any more (tested on current branch). Is this PR still needed?

FSchumacher avatar Apr 23 '23 10:04 FSchumacher

This was created to address #5539, but the attached test case does not fail any more (tested on current branch). Is this PR still needed?

For me the attached test case still fails - please see https://github.com/apache/jmeter/issues/5539#issuecomment-1520035988

andreaslind01 avatar Apr 24 '23 12:04 andreaslind01

PR has been merged. Thanks for your PR and your insistence :) Could you test the current trunk or next nightly?

FSchumacher avatar Apr 29 '23 15:04 FSchumacher

Thanks for merging the PR @FSchumacher. I've tested it with the current nightly and it works like a charm :)

andreaslind01 avatar May 04 '23 08:05 andreaslind01