jmeter icon indicating copy to clipboard operation
jmeter copied to clipboard

Ensure directories are writable when generating reports from read-only sources

Open FSchumacher opened this issue 1 year ago • 2 comments

Description

When copying files while generating reports, make newly created directories writeable.

Motivation and Context

As reported in #6357 some distributions of JMeter provide the template directories read-only, only. As that is probably a good idea, we should support those kind of setups.

How Has This Been Tested?

Made some directories in ./bin/report-templates read-only and generated a report. With the current released version of JMeter we will get an exception as described in #6357. With the fix, the report is generated without problems.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have updated the documentation accordingly.

FSchumacher avatar Oct 04 '24 14:10 FSchumacher

Could we make the folders read-only in CI?

vlsi avatar Oct 04 '24 14:10 vlsi

Could we make the folders read-only in CI?

I added a test case, but I am sure, that you could make that a bit nicer than me :)

FSchumacher avatar Oct 04 '24 16:10 FSchumacher

Has been merged into master

FSchumacher avatar Oct 25 '24 11:10 FSchumacher