jena icon indicating copy to clipboard operation
jena copied to clipboard

Fuseki UI Add Data Dataset graph name not escaped

Open afs opened this issue 1 year ago • 5 comments
trafficstars

Version

4.8.0

What happened?

(Transferred from https://issues.apache.org/jira/browse/JENA-2359)

@jmkeil wrote:

If uploading some data through the Fuseki UI (#/dataset/<dataset>/upload), the name of the target graph will not be URI save escaped for the HTTP service request. If I enter e.g. http://example.org/dataset#graph, the data will be added to the named graph http://example.org/dataset. However, if I enter http://example.org/dataset%23graph, the data will be added to the named graph http://example.org/dataset#graph.

afs avatar Mar 27 '24 08:03 afs

Off topic question: Is GitHub now the official place to report and discuss Apache Jena issues?

jmkeil avatar Mar 27 '24 08:03 jmkeil

Off topic question: Is GitHub now the official place to report and discuss Apache Jena issues?

GitHub issues has become the preferred channel for Jena. We have been running them in parallel and github is now much busier. github is now preferred for Jena. We have also enabled the discussions forum.

We keep JIRA around. Some people who may dip in and out occasionally are used to using it.

ASF generally now requires some confirmation for any new JIRA user signups due to JIRA spam. JIRA spam had become a real problem for the foundation. Jena only got a small amount, other projects were not so lucky.

For Jena, >80% of signups have been spam attempts.

Other Apache projects still use JIRA as their primary tracker.

afs avatar Mar 27 '24 09:03 afs

@afs how do you think this should be tackled? Escape on UI? Escape on backend? Escape on both (not sure if double-escaping could lead to some other issue).

(Although re-reading it, maybe it can only be fixed on the UI?)

kinow avatar Mar 27 '24 09:03 kinow

It must be handled in the front-end, as the request to the back-end is a SPARQL 1.1 Graph Store HTTP Protocol POST request with the graph IRI as URL parameter.

jmkeil avatar Mar 27 '24 10:03 jmkeil

Reproduced, found where to change. Just checking what's the possible best way to fix it, then will prepare a draft PR and if that looks OK will write a test for that.

kinow avatar Mar 27 '24 11:03 kinow