jena icon indicating copy to clipboard operation
jena copied to clipboard

GH-2297: Add CORS configuration file as command line parameter to Fuseki Main

Open TelicentPaul opened this issue 1 year ago • 3 comments

GitHub issue resolved #2297

Pull request Description: Enabling the potential passing of a configuration file containing the desired CORS configuration so that we have a greater choice than present - none or default.

Also some tidying up of spellings, some better error checks and improved testing of the existing Cross Origin Filter class and all of the exceptional cases for Fuseki Main's command-line arg processing.


  • [x] Tests are included.
  • [x] Documentation change and updates are provided for the Apache Jena website
  • [x] Commits have been squashed to remove intermediate development commit messages.
  • [x] Key commit messages start with the issue number (GH-xxxx, or if in JIRA, JENA-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

TelicentPaul avatar Feb 26 '24 16:02 TelicentPaul

@kinow Could you take a look over this PR please, I know you do a lot of front end stuff atop Fuseki so figure this is probably useful to you long term and worth double checking it would address any CORS configuration needs you've encountered previously

rvesse avatar Feb 28 '24 14:02 rvesse

Could you rebase this against current main please?

The build does not work - it runs into a bug in a dependency that's now been upgraded to a working version.

afs avatar Feb 28 '24 15:02 afs

I'm assuming that's the Maven Javadoc plugin, yeah? I'd noticed problems with it and had commented it out locally as it bore no relation to this work. Rebasing shouldn't be a problem.

TelicentPaul avatar Feb 28 '24 15:02 TelicentPaul

@afs I've changed the header in tests for "Custom-Header".

TelicentPaul avatar Mar 04 '24 09:03 TelicentPaul

afs avatar Mar 04 '24 11:03 afs