jena icon indicating copy to clipboard operation
jena copied to clipboard

Fuseki UI broken for "edit" tab when number of graphs is large

Open LorenzBuehmann opened this issue 1 year ago • 4 comments

Version

4.10.0

What happened?

Reported on mailing list: https://lists.apache.org/thread/zdtjtl3qlypl7d713z7bd1117kfjq149

The Fuseki UI is broken when we work on a large number of graphs and open the "edit" tab, see image

You can reproduce it with

for i in {1..100..1}; do echo "<http://example.org/s> <http://example.org/p> <http://example.org/o> <http://example.org/g$i> ." >> /tmp/data.nq; done
$JENA_HOME/bin/tdb2.tdbloader --loc /tmp/tdb2/debug /tmp/data.nq
$FUSEKI_HOME/fuseki-server --loc /tmp/tdb2/debug --port 3333 /ds

Relevant output and stacktrace

No response

Are you interested in making a pull request?

No

LorenzBuehmann avatar Feb 12 '24 08:02 LorenzBuehmann

Ah, yo umean because of how the pagination component is being rendered, @LorenzBuehmann ? Should be easy to fix if that's the problem.

kinow avatar Feb 12 '24 09:02 kinow

Yes, I mean there are page numbers missing for sure when having hundreds of graph - note, I do not use the "edit" tab at all in Fuseki. I just reported the issue. Not sure if that is the real problem of the mailing list thread - but they user said "was working before" - not that I know which version this statement refers to

LorenzBuehmann avatar Feb 12 '24 11:02 LorenzBuehmann

I also don't use that page, unless when I want to test some quick changes in small graphs.

Will fix that pagination as that is definitely broken. Once that's fixed I will look at the ASF lists archive and reply to that thread. Thanks @LorenzBuehmann !

kinow avatar Feb 12 '24 11:02 kinow

Synced code, updated IDE's (phew, that took a while), and reproduced with the example from issue description (thanks!).

image

kinow avatar Feb 17 '24 21:02 kinow

Still need to write tests, but here's a preview.

image

image

image

And while navigating through the rest of the UI, I noticed when clicking on the Dataset size count button, in the information about the dataset, it also created a really long list of graphs and count of triples per graph.

image

I will see whether we need/can add a scrollable area, or pagination here too (probably the latter, less surprise to users, more uniform...).

kinow avatar Mar 05 '24 22:03 kinow

Added the same table to the info view now:

image

image

kinow avatar Mar 05 '24 22:03 kinow

Now just missing the unit/e2e tests, to be completed next spare time window :crossed_swords: :muscle:

kinow avatar Mar 05 '24 22:03 kinow