apache
JENA-2282: Fuseki2 Query Store
Jira issue: https://issues.apache.org/jira/browse/JENA-2282
Pull request Description:
An initial implementation of a query library for the Fuseki2 Vue UI using Vuex. Adds two buttons to the dataset query page for saving & loading queries. From there, users can save queries to a query library that persists in local storage in the browser.
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the Apache Jena website
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.
Hi @jamiefeiss!
Great to see this!
It is showing as having a conflict with the main branch of the codebase. There is major maintenance PR #1307and we've made some version upgrades due to a security alert.
Your PR branch is showing as 77 commits behind main so it looks (please confirm) that it is just behind on main and isn't a PR relative to the Vue upgrade work.
@kinow what order of PRs should we work with?
We're approaching a release (early August?) - I'm neutral as to whether this goes in before or after. Mostly, Jena releases are done on a regular tick, and not feature driven. Features take the time they take!
@kinow what order of PRs should we work with?
If @jamiefeiss doesn't mind, I think it'd be easier to get the #1307 in first, as that one also adds the e2e tests. Later, if needed, I can help converting this PR from Bootstrap 4 to Bootstrap 5, and help with e2e tests as well. I haven't reviewed the code yet, but if it changes the Query editor we can add some tests first to main, and then confirm this change doesn't add any regression.
Thanks @afs & @kinow.
I'm fine with waiting for the other PR first. Once the other PR is done, I'll get this PR up to date with main, update my code to use Bootstrap 5 and write some tests.
#1307 has merged.
I'd like to get a Jena release because it has been slipping for multiple reasons, none due to any UI work.
There are several PRs queued and we can't wait for them to complete because while that happens, others appear!
So I'll wait a few days then release what is ready at the time.
The Vue 3 migration work (issue #1306 PR #1480) has been completed!
Hopefully, that clears the way for this PR.