james-project
james-project copied to clipboard
apache
Avoid sorting PG messages
14:47:21,240 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project apache-james-mailbox-postgres: You have 1 Checkstyle violation. -> [Help 1]
Why avoiding the sort btw?
Why avoiding the sort btw?
The retrieveFullContent fetched bodyContent from ObjectStorage, it is quite heavy.
In the past, I wanted to it concurrency, I used flatMap, but the result after flatmap was not sorted -> some test cases did not pass. -> using .sort to resolve that.
Looks like we can also resolve that by flatmapSequential (ensuring the order inside the reactor)
Why avoiding the sort btw?
Because in order to sort you need to have all the entities sorted at hand first.
seems related: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1964/3/
09:37:35,066 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project apache-james-mailbox-postgres: You have 1 Checkstyle violation. -> [Help 1]
Related : https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1964/6/#showFailuresLink
Same as what has been reported before already btw => https://github.com/apache/james-project/pull/1964#issuecomment-1920642886