james-project
james-project copied to clipboard
JAMES-3775 Guice packaging for RSpamd
Remark:
- James is not supporting the extension for
Task json dto
. - We cannot declare Guice inject for
webadmin-dto
by normal way:
@Named(DTOModuleInjections.WEBADMIN_DTO)
@ProvidesIntoSet
public AdditionalInformationDTOModule<? extends TaskExecutionDetails.AdditionalInformation, ? extends AdditionalInformationDTO> webAdminFeedSpamAdditionalInformation() {
...
}
(Guice throws an error)
-> Don't allow the use of the routes for now.
What do you mean don't allow the use of the routes for now???
What do you mean don't allow the use of the routes for now???
yes, because we can't start James.
@chibenwa opinion
That's not possible yet...
- 1. for now cheat: don't allow the use of the routes for now.
- 2. Write on the mailing list about your need.
- 3. We will define and contribute such an extension mechanism
Cleaning up the workspace
/home/jenkins/jenkins-agent/workspace/james: Read-only file system
Likely related to the latest Jenkins cleanup commit.
We already have manually docker-compose-distributed.yml
Should we still have a deployment test?
@vttranlina needs a rebase :)
@vttranlina needs a rebase :)
I tried to rebase, but this pr depends on many other pr. It has a bit complex to rebase & resolve. So, I will rebase this pr later, after more pr has been merged. It will be better
Conflict spotted