jackrabbit-oak icon indicating copy to clipboard operation
jackrabbit-oak copied to clipboard

Published 20 hours ago • verified publisher icon apache

OAK-10375: remove binary data from logs

Open steffenvan opened this issue 11 months ago • 2 comments

If there is an error while indexing a binary property, we shouldn't log the data. We should just log the property name.

Current

ERROR o.a.j.o.p.i.l.LuceneDocumentMaker - could not index similarity field for property 
haystack0 = <LONG GARBLED BINARY DATA>

This PR

ERROR o.a.j.o.p.i.l.LuceneDocumentMaker - could not index similarity field for property 
haystack0

steffenvan avatar Mar 07 '24 16:03 steffenvan

Hmm as long as it doesn't violate any privacy concerns, I guess so. @reschke

steffenvan avatar Mar 18 '24 15:03 steffenvan

That's a good point. Paths can contain senstive information as well, but I believe we use them alaready almost everywhere, because that information is really essential for debugging.

reschke avatar Mar 19 '24 08:03 reschke