jackrabbit-oak icon indicating copy to clipboard operation
jackrabbit-oak copied to clipboard

OAK-6766: Convert oak-lucene to OSGi R7 annotations

Open mbaedke opened this issue 1 year ago • 4 comments

mbaedke avatar Mar 07 '24 14:03 mbaedke

Would be good to get feedback from the Lucene team for this.

Definitely

Maybe the issue of "private" properties can be simplified?

Now that I realized that they can be retrieved directly from the ComponentContext without needing a reference to the ConfigurationAdmin service (see last commit), I don't think it can get simpler anymore.

mbaedke avatar Mar 12 '24 08:03 mbaedke

I don't think it can get simpler anymore.

Have you tried adding the private property names to the annotation, but leaving the @Attribute meta-annotation off? I have a feeling that could work, and you could then access the values more easily. YMMV, I am not 100% certain.

jsedding avatar Mar 12 '24 12:03 jsedding

@jsedding Yes, I tried that :)

mbaedke avatar Mar 12 '24 13:03 mbaedke

Addressed @kwin 's suggestions.

mbaedke avatar Mar 21 '24 09:03 mbaedke