iotdb icon indicating copy to clipboard operation
iotdb copied to clipboard
verified publisher icon apache

[ISSUE-3857] Support show now() function

Open RYH61 opened this issue 3 years ago • 7 comments

Description

Content1 ...

Content2 ...

Content3 ...

This PR has:

  • [ ] been self-reviewed.
    • [ ] concurrent read
    • [ ] concurrent write
    • [ ] concurrent read and write
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] added Javadocs for most classes and all non-trivial methods.
  • [ ] added or updated version, license, or notice information
  • [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
  • [ ] added integration tests.
  • [ ] been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

RYH61 avatar Feb 17 '22 15:02 RYH61

Coverage Status

Coverage decreased (-0.1%) to 67.67% when pulling 90793fd3e56beb1dd6f4fe12fe06fb59e3188ffe on RYH61:fix_ryh into e95789cb190940c825ea7360f4a90857706fe4e6 on apache:master.

coveralls avatar Feb 17 '22 16:02 coveralls

please add cluster tests.

mychaow avatar Feb 18 '22 03:02 mychaow

Hi, any user guide to show the function definition and usage?

HTHou avatar Feb 21 '22 02:02 HTHou

It seems that now() can be a special aggregation function.

How do you think? @neuyilan @mychaow @HTHou

SteveYurongSu avatar Feb 21 '22 15:02 SteveYurongSu

From a coding point of view, it is very similar to aggregation. From a functional point of view, it is one of my commands, so maintenance in different regions is also possible.

mychaow avatar Feb 25 '22 04:02 mychaow

From a coding point of view, it is very similar to aggregation. From a functional point of view, it is one of my commands, so maintenance in different regions is also possible.

How about split it into two functions? One is select now() just like an aggregation, another is show node info as a maintenance command...

HTHou avatar Mar 02 '22 06:03 HTHou

From a coding point of view, it is very similar to aggregation. From a functional point of view, it is one of my commands, so maintenance in different regions is also possible.

How about split it into two functions? One is select now() just like an aggregation, another is show node info as a maintenance command...

ok， split it to two functions.

mychaow avatar Mar 14 '22 02:03 mychaow