Use Maven Wrapper in CI
Makes the version of Maven used consistent across all builds.
[!NOTE] Before this change some scripts were using the version of Maven defined by the wrapper, and some could have been using the version that was on the
PATH.
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, license, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR
Hi, any advantage of this change?
Hi, any advantage of this change?
Mostly consistency. Most of the IoTDB CI builds are already using the wrapper, but the ones in this change were not.
Without all the builds using the same version we could end up in a situation where we see different behavior on some builds and it would be difficult to troubleshoot.
I think the most of IoTDB developers are using the maven on the PATH to dev, test, build and release binary packages. We have no report of the problem about the maven version before. From my side, I think it is no necessary to change that for now. Should rise a discussion on the mail list?
I think the most of IoTDB developers are using the maven on the
PATHto dev, test, build and release binary packages. We have no report of the problem about the maven version before. From my side, I think it is no necessary to change that for now. Should rise a discussion on the mail list?
This is totally up to you. However, I'd recommend, being consistent here in using one or the other
This change specifically called out needing to use the wrapper to avoid the type of problems I mentioned https://github.com/apache/iotdb/commit/09f9bcfedf68d619f5bd6250b4603e3126b6d855
Given that Maven 4 is around the corner, using the wrapper, is another easy way to help with migrating (e.g. single place to update the Maven version). Similar if in the future IoTDB wants to use mvnd (Maven Daemon)