inlong icon indicating copy to clipboard operation
inlong copied to clipboard

Published 20 hours ago • verified publisher icon apache

[INLONG-4962][DataProxy] Unify the MQ zone sink

Open liangyepianzhou opened this issue 2 years ago • 6 comments

Prepare a Pull Request

  • Fixes https://github.com/apache/inlong/issues/4962

Motivation&&Modifications

implement AbstractClusterZoneProducer and AbstractSinkZoneContext. Implement the AbstractZoneProducer. implement the AbstractZoneSink and AbstractZoneWork.

liangyepianzhou avatar Aug 02 '22 03:08 liangyepianzhou

@dockerzhang Could you please help review this PR wehn you have time? THX.

liangyepianzhou avatar Aug 02 '22 03:08 liangyepianzhou

@liangyepianzhou please fix the checkstyles error.

dockerzhang avatar Aug 02 '22 06:08 dockerzhang

@liangyepianzhou please fix the checkstyles error.

Fixed.

liangyepianzhou avatar Aug 02 '22 07:08 liangyepianzhou

@dockerzhang @healchow All tests have passed, please help review this PR, THX.

liangyepianzhou avatar Aug 03 '22 06:08 liangyepianzhou

What's more, please add necessary UT, thanks.

pocozh avatar Aug 10 '22 05:08 pocozh

What's more, please add necessary UT, thanks.

The https://github.com/apache/inlong/issues/5321 is adding the missing zone sink test.

liangyepianzhou avatar Aug 11 '22 15:08 liangyepianzhou