inlong icon indicating copy to clipboard operation
inlong copied to clipboard

[Improve][Sort] New so many MetricsController obejects

Open XiaoYou201 opened this issue 1 year ago • 1 comments

Description

The audit information will report when every records deserializing, So,it will new many MetricsController objects.

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/PulsarTableDeserializationSchema.java#L99-L118

And MetricController not has SinkMetricData property, So, it should be add to MetricController

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java#L28-L35

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/SinkMetricData.java#L45-L60

InLong Component

InLong Sort

Are you willing to submit PR?

  • [X] Yes, I am willing to submit a PR!

Code of Conduct

XiaoYou201 avatar May 17 '24 06:05 XiaoYou201

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar Jul 17 '24 01:07 github-actions[bot]

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar Dec 10 '24 02:12 github-actions[bot]