incubator-xtable
incubator-xtable copied to clipboard
Added support for dynamically getting delta table features
Important Read
To address: Issue #354
What is the purpose of the pull request
This pull request implements dynamically capturing the min reader and writer version of a target delta table, based on its table details.
Brief change log
- Forked the current version of main
- Copied @the-other-tim-brown initial changes from the #382 into this fork
- The bulk of the changes were related to the getConfigurationsForDeltaSync() method from the DeltaConversionTarget.java
Verify this pull request
This pull request is already covered by existing tests, i think...
This is my first PR to an open source project - i was a bit unsure of how to do the unit test for this change. Any pointers or insight would be welcomed :) !
@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main
to pick up the path changes?
CI report:
Bot commands
@xtable-bot supports the following commands:-
@xtable-bot run azure
re-run the last Azure build
Sure. Also, I'm not really versed in writing java test. So I'm flying a bit blind here, in terms if those are correct or not. Any pointers would be appreciated.
On Sun, May 26, 2024, 8:00 PM Tim Brown @.***> wrote:
@ForeverAngry https://github.com/ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main to pick up the path changes?
— Reply to this email directly, view it on GitHub https://github.com/apache/incubator-xtable/pull/428#issuecomment-2132440434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOXHQZAFKJ5YM6FMSGFNLUTZEJZQZAVCNFSM6AAAAABG65VQ36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGQ2DANBTGQ . You are receiving this because you were mentioned.Message ID: @.***>
@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from
main
to pick up the path changes?
@the-other-tim-brown sure. Also, I don't have a lot of experience writing java test. Can you point out what I need to fix, to please the bot :)?
@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from
main
to pick up the path changes?@the-other-tim-brown sure. Also, I don't have a lot of experience writing java test. Can you point out what I need to fix, to please the bot :)?
There were some issues with the test infra but those should be resolved now. After pushing your next commit, it should kick off a new run and I'll take a look at the results