incubator-xtable icon indicating copy to clipboard operation
incubator-xtable copied to clipboard

Website header add ASF menu

Open wuchunfu opened this issue 11 months ago • 7 comments

Website header add ASF menu

wuchunfu avatar Mar 16 '24 02:03 wuchunfu

CI report:

  • 2b855f5312b9668fe65c1d8a06468ee13fe795f8 Azure: SUCCESS
Bot commands @xtable-bot supports the following commands:
  • @xtable-bot run azure re-run the last Azure build

ghost avatar Mar 16 '24 03:03 ghost

@the-other-tim-brown @zabetak @vinothchandar @jcamachor PTAL, thanks

wuchunfu avatar Mar 17 '24 17:03 wuchunfu

I am building the site locally but I don't see the new menu. Can you please share the steps that you did to test this change?

@zabetak Thank you for your review. The red box represents the effect of the modifications I made this time image

wuchunfu avatar Mar 20 '24 10:03 wuchunfu

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

zabetak avatar Mar 20 '24 11:03 zabetak

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

@zabetak Oh, it's my fault. When I run the npm run start command, it can appear, but now the organization of this document doesn't seem to be a standard docusaurus. The index page now looks like a fixed index.html file. Normal docusaurus can be generated automatically. Do you need to adjust it to standard docusaurus?

wuchunfu avatar Mar 20 '24 12:03 wuchunfu

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

zabetak avatar Mar 21 '24 08:03 zabetak

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

Yes, I will finish this work later, but this method is a bit troublesome. Actually, the top menu docusaurus will be automatically generated, and I plan to optimize this content later

wuchunfu avatar Mar 21 '24 10:03 wuchunfu