incubator-xtable icon indicating copy to clipboard operation
incubator-xtable copied to clipboard

Published 20 hours ago • verified publisher icon apache

#306 - [DRAFT] Introduce Injection of PerTableConfig params into TargetClients by the Factory

Open lmccay opened this issue 6 months ago • 3 comments

As described in #306 , this PR introduces injection of config params into TargetClient implementation classes. It removes the need for the api module and the init() in the TargetClient interface. It moves interfaces that were added for #304 back to the core module and will perhaps remove them again since this abstraction may no longer be needed. This is an open question.

Brief change log

  • added injection code to the TableFormatClientFactory class
  • added required setters to each TargetClient implementation
  • removed PerTableConfig from the init() args
  • moved interfaces related to PerTableConfig back to core
  • changed TestTableFormatClientFactory to align with and exercise the injection path

Verify this pull request

Ran existing tests and modified TestTableFormatClientFactory to align with and cover this path

lmccay avatar Jan 07 '24 07:01 lmccay