incubator-weex [android] android targetSdkVersion 29 ashmem issue

As Google Play warn all apps need update targetSdkVersion to 29 before 2020.10, We must handle this issue, https://github.com/apache/incubator-weex/issues/2706

Jul 27 '20 03:07 neuyu

Warnings

:warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md

:warning: Current pr not bind the milestone

:warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

	Warnings
:warning:	No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
:warning:	Current pr not bind the milestone
:warning:	If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

Generated by :no_entry_sign: dangerJS against 8c5d8489430a5c8ea0028e941ac5b7639a1867e2

Jul 27 '20 03:07 weex-bot

Successful self-test

Jul 27 '20 06:07 neuyu

Fails

:no_entry_sign: AndroidLint Result

:no_entry_sign:

Missing Permissions

../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE
407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication                                                       411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException | NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e));

../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE
407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication                                                       411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException | NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e));

This check scans through your code and libraries and looks at the APIs being used, and checks this against the set of permissions required to access those APIs. If the code using those APIs is called at runtime, then the program will crash.

Furthermore, for permissions that are revocable (with targetSdkVersion 23), client code must also be prepared to handle the calls throwing an exception if the user rejects the request for permission at runtime.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "MissingPermission" as explained in the Suppressing Warnings and Errors section.

MissingPermission Correctness Error Priority 9/10

:no_entry_sign: AndroidLint Result

:no_entry_sign:

Missing Permissions

../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE
407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication                                                       411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException | NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e));

../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE
407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication                                                       411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException | NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e));

This check scans through your code and libraries and looks at the APIs being used, and checks this against the set of permissions required to access those APIs. If the code using those APIs is called at runtime, then the program will crash.

Furthermore, for permissions that are revocable (with targetSdkVersion 23), client code must also be prepared to handle the calls throwing an exception if the user rejects the request for permission at runtime.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "MissingPermission" as explained in the Suppressing Warnings and Errors section.

MissingPermission Correctness Error Priority 9/10

	Fails
:no_entry_sign:	AndroidLint Result
:no_entry_sign:	Missing Permissions ../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE 407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication 411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException \| NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e)); ../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE 407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication 411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException \| NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e)); This check scans through your code and libraries and looks at the APIs being used, and checks this against the set of permissions required to access those APIs. If the code using those APIs is called at runtime, then the program will crash. Furthermore, for permissions that are revocable (with targetSdkVersion 23), client code must also be prepared to handle the calls throwing an exception if the user rejects the request for permission at runtime. Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA. To suppress this error, use the issue id "MissingPermission" as explained in the Suppressing Warnings and Errors section. MissingPermission Correctness Error Priority 9/10
:no_entry_sign:	AndroidLint Result
:no_entry_sign:	Missing Permissions ../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE 407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication 411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException \| NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e)); ../../src/main/java/org/apache/weex/WXEnvironment.java:410: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE 407 String ret = ""; 408 if(sApplication != null){ 409 try{ 410 ret = ((TelephonyManager) sApplication 411 .getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId(); 412 }catch (SecurityException \| NullPointerException e){ 413 WXLogUtils.e(WXLogUtils.getStackTrace(e)); This check scans through your code and libraries and looks at the APIs being used, and checks this against the set of permissions required to access those APIs. If the code using those APIs is called at runtime, then the program will crash. Furthermore, for permissions that are revocable (with targetSdkVersion 23), client code must also be prepared to handle the calls throwing an exception if the user rejects the request for permission at runtime. Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA. To suppress this error, use the issue id "MissingPermission" as explained in the Suppressing Warnings and Errors section. MissingPermission Correctness Error Priority 9/10

Generated by :no_entry_sign: dangerJS against 8c5d8489430a5c8ea0028e941ac5b7639a1867e2

Jul 27 '20 06:07 weex-bot

Just judging the api level is a problem with Android R.Should judge target sdk version and api level together. if (g_targetSDKInt >= 29 && device_api_level() >= 29)