incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1264][FEATURE][SPARK] Support cancel async thread of handle blockEvent and rpc when writer is killed

Open summaryzb opened this issue 9 months ago β€’ 6 comments

What changes were proposed in this pull request?

Cancel all the runnable that are wait to be executed or blocked in waiting for rpc callback

Why are the changes needed?

This is helpful when current task is killed since speculation task attempts succeed, but the rpc of which send data still keep retrying

Fix: #1264

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT

summaryzb avatar Mar 06 '25 04:03 summaryzb

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.21%. Comparing base (8ad0f8d) to head (7b0f563). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ffle/client/request/RssSendShuffleDataRequest.java 0.00% 4 Missing :warning:
...ffle/client/impl/grpc/ShuffleServerGrpcClient.java 0.00% 1 Missing :warning:
...client/impl/grpc/ShuffleServerGrpcNettyClient.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2381      +/-   ##
============================================
- Coverage     51.34%   51.21%   -0.14%     
+ Complexity     3615     3016     -599     
============================================
  Files           571      481      -90     
  Lines         32892    23193    -9699     
  Branches       2833     2140     -693     
============================================
- Hits          16890    11878    -5012     
+ Misses        14932    10569    -4363     
+ Partials       1070      746     -324     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 06 '25 04:03 codecov-commenter

Test Results

 3β€ˆ008 files   -β€Š11   3β€ˆ008 suites   -β€Š11   6h 38m 27s ⏱️ - 6m 23s  1β€ˆ178 tests ± 0   1β€ˆ175 βœ…  -β€Šβ€‡2   1 πŸ’€ Β±0  0 ❌ Β±0  2 πŸ”₯ +2  14β€ˆ911 runsβ€Š  -β€Š11  14β€ˆ893 βœ…  -β€Š14  15 πŸ’€ Β±0  0 ❌ Β±0  3 πŸ”₯ +3 

For more details on these errors, see this check.

Results for commit be8ca4e7. ± Comparison against base commit 94e211c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 06 '25 05:03 github-actions[bot]

@jerqi @LuciferYang PTAL

summaryzb avatar Mar 06 '25 07:03 summaryzb

also cc @advancedxy

LuciferYang avatar Mar 06 '25 07:03 LuciferYang

Seems we should add a new test to cover this

LuciferYang avatar Mar 06 '25 07:03 LuciferYang

gentle ping @LuciferYang @advancedxy

summaryzb avatar Mar 08 '25 04:03 summaryzb