incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#2030] fix(client-spark): Remove javax and logging from relocation list to solve NoClassDefFoundError

Open maobaolong opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Do not relocate javax to avoid NoClassDefFoundError issue.

Why are the changes needed?

Fix: #2030

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Thanks for the verify check by @zhengchenyu . This is not reproduced on my env.

maobaolong avatar Aug 10 '24 00:08 maobaolong

Test Results

 2 760 files   - 32   2 760 suites   - 32   5h 38m 7s :stopwatch: - 12m 10s    988 tests ± 0     985 :white_check_mark:  -  2   1 :zzz: ±0  2 :x: +2  12 342 runs   - 61  12 325 :white_check_mark:  - 63  15 :zzz: ±0  2 :x: +2 

For more details on these failures, see this check.

Results for commit 25576f6c. ± Comparison against base commit 3673b559.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 10 '24 01:08 github-actions[bot]

Could you help review this? @zhengchenyu

zuston avatar Aug 19 '24 03:08 zuston

@jerqi Please help to review this PR, thanks!

maobaolong avatar Aug 28 '24 06:08 maobaolong

@jerqi thanks for your review

maobaolong avatar Sep 20 '24 04:09 maobaolong