incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

Published 20 hours ago • verified publisher icon apache

[#1608] refactor: Reuse ShuffleManagerClient in ShuffleReader and ShuffleWriter

Open xumanbu opened this issue 8 months ago • 5 comments

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

  1. The createShuffleManagerClient function is defined in both RssShuffleWriter and RssFetchFailedIterator.
  2. The ShuffleManagerClient is created in RssShuffleManager when shuffleManagerRpcServiceEnabled is true. We can reuse the client in RssShuffleReader and RssShuffleWriter.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

xumanbu avatar Jun 26 '24 13:06 xumanbu