incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Bug] Assertions will not take effect during production runtime

Open rickyma opened this issue 1 year ago • 0 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

Describe the bug

We have many assertions in our code, and these will only take effect when running test cases because the -ea parameter is enabled when running tests. However, they will not take effect in actual production because we do not include the -ea parameter in the startup arguments, and enabling assertions can also impact performance, so it is not recommended to enable them. We should refactor them, maybe replacing these assertions with exception-throwing methods.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

rickyma avatar Apr 25 '24 13:04 rickyma