incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Umbrella] Enhance dashboard capabilities.

Open yl09099 opened this issue 2 years ago • 14 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

Describe the proposal

You can configure one dashboard to manage multiple clusters, and add dashboard management functions for Coordinators and ShuffleServer.Reference documents for specific functions: https://docs.google.com/document/d/1pR-pTn3aIZHpKSYDmFVdTijDwaT7INFVXJd5VG0WVpg/edit

Task list

  • Added the ability for the dashboard to connect to multiple coordinators and shuffle servers.
  • Add sorting and search functions to the dashboard list area for ease of use.
  • Added the dashboard account password login function.
  • Dashboard added functions for adding and deleting ShuffleServer nodes offline and blacklist.
  • Added monitoring status indicators of the ShuffleServer node.
  • https://github.com/apache/incubator-uniffle/issues/1618
  • https://github.com/apache/incubator-uniffle/issues/1622
  • https://github.com/apache/incubator-uniffle/issues/1623
  • https://github.com/apache/incubator-uniffle/issues/1624
  • https://github.com/apache/incubator-uniffle/issues/1688

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

yl09099 avatar Dec 28 '23 02:12 yl09099

@zuston @jerqi @lifeSo Let's see if these functions make sense.

yl09099 avatar Dec 28 '23 02:12 yl09099

@zuston @jerqi @lifeSo Let's see if these functions make sense.

OK, I am new to dashboard, let's me see see first and will try.

lifeSo avatar Dec 28 '23 09:12 lifeSo

Is the current dashboard functioning correctly? I see many 404 error requests on all dashboard pages. image image image @yl09099 @lifeSo @jerqi

Is the code up to date?

yl09099 avatar Jan 02 '24 02:01 yl09099

It's up to date. I don't know why this is happening. Am I missing something? @yl09099

Is the Coordinator interface access address correctly configured? The error is that the interface cannot be accessed,Refer to configuration here:https://github.com/apache/incubator-uniffle/blob/master/docs/dashboard_guide.md.

yl09099 avatar Jan 02 '24 03:01 yl09099

So I am just wondering, if the latest code works fine?

You should have no problem using the latest version of the code.

yl09099 avatar Jan 02 '24 06:01 yl09099

Can we display usedDirectMemory on the Dashboard's shuffle server page(which is very useful in my opinion)? Maybe add a column? If you think there are too many columns and it doesn't look nice, can we remove the first column Id? Displaying Id on the page doesn't serve any purpose, right? Id can be composed of the values in the following columns (IP + GrpcPort + NettyPort).

PTAL @yl09099

rickyma avatar Jan 15 '24 17:01 rickyma

I personly do not think add usedDirectMemory is necessary if your company have other monitor system like:

image

If I want to see the metric, I will use metric system instead of dashboard.

lifeSo avatar Jan 16 '24 05:01 lifeSo

Id can be composed of the values in the following columns (IP + GrpcPort + NettyPort).

@yl09099 What do you think ?

lifeSo avatar Jan 16 '24 05:01 lifeSo

image usedDirectMemory has already become a very important metric in the latest Uniffle(especially when enabling Netty).

I'm just making a suggestion for your reference. Since the Id is not very useful anymore(actually useless), you might as well conveniently replace it with usedDirectMemory.

@lifeSo

rickyma avatar Jan 16 '24 06:01 rickyma

It is my personal opinion, if you persist it. I just think dashboard is the place to operate server, and there is monitor system to see metric. @jerqi @yl09099 What's your idea?

lifeSo avatar Jan 16 '24 09:01 lifeSo

Can we display usedDirectMemory on the Dashboard's shuffle server page(which is very useful in my opinion)? Maybe add a column? If you think there are too many columns and it doesn't look nice, can we remove the first column Id? Displaying Id on the page doesn't serve any purpose, right? Id can be composed of the values in the following columns (IP + GrpcPort + NettyPort).

PTAL @yl09099

I don't think it's useful either. We can change it.

yl09099 avatar Jan 24 '24 05:01 yl09099

I personly do not think add usedDirectMemory is necessary if your company have other monitor system like:

image

If I want to see the metric, I will use metric system instead of dashboard.

I also do not have what good idea, document change inside, https://docs.google.com/document/d/1pR-pTn3aIZHpKSYDmFVdTijDwaT7INFVXJd5VG0WVpg/edit

yl09099 avatar Jan 24 '24 05:01 yl09099

Id can be composed of the values in the following columns (IP + GrpcPort + NettyPort).

@yl09099 What do you think ?

I think it's useless. We can change it.

yl09099 avatar Jan 24 '24 05:01 yl09099

I think this is not finished yet.

rickyma avatar Jun 21 '24 14:06 rickyma