incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Improvement] `rss.client.assignment.shuffle.nodes.max` should not be less than `rss.data.replica`

Open xianjingfeng opened this issue 1 year ago • 1 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

For current assignment strategy, if rss.client.assignment.shuffle.nodes.max less than rss.data.replica, the duplicate shuffle server will be included in the replicas.

How should we improve?

Check if rss.client.assignment.shuffle.nodes.max less than rss.data.replica in the client side. We can modify the following method.

https://github.com/apache/incubator-uniffle/blob/10e8e3d2eb553146d9729e5dac2bde20f71c3358/common/src/main/java/org/apache/uniffle/common/util/RssUtils.java#L310C22-L319

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

xianjingfeng avatar Sep 14 '23 06:09 xianjingfeng

Kindly to ask if there is somebody working for this issue? If not, i'm glad to undertake it.

somelovelanguage avatar Feb 08 '24 03:02 somelovelanguage